Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: src/heap/embedder-tracing.h

Issue 2592393003: Revert of Reland "[heap] Ensure progress when incrementally marking wrappers" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/embedder-tracing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/embedder-tracing.h
diff --git a/src/heap/embedder-tracing.h b/src/heap/embedder-tracing.h
index 5e10d6e2e87f2acfe3948a6dc10994a52b5b7243..60c85cd52f285a5d6c85794216a7da22a39fb00b 100644
--- a/src/heap/embedder-tracing.h
+++ b/src/heap/embedder-tracing.h
@@ -6,7 +6,6 @@
#define V8_HEAP_EMBEDDER_TRACING_H_
#include "include/v8.h"
-#include "src/flags.h"
#include "src/globals.h"
namespace v8 {
@@ -18,8 +17,7 @@
public:
typedef std::pair<void*, void*> WrapperInfo;
- LocalEmbedderHeapTracer()
- : remote_tracer_(nullptr), num_v8_marking_deque_was_empty_(0) {}
+ LocalEmbedderHeapTracer() : remote_tracer_(nullptr) {}
void SetRemoteTracer(EmbedderHeapTracer* tracer) { remote_tracer_ = tracer; }
bool InUse() { return remote_tracer_ != nullptr; }
@@ -45,20 +43,11 @@
// are too many of them.
bool RequiresImmediateWrapperProcessing();
- void NotifyV8MarkingDequeWasEmpty() { num_v8_marking_deque_was_empty_++; }
- bool ShouldFinalizeIncrementalMarking() {
- static const size_t kMaxIncrementalFixpointRounds = 3;
- return !FLAG_incremental_marking_wrappers || !InUse() ||
- NumberOfWrappersToTrace() == 0 ||
- num_v8_marking_deque_was_empty_ > kMaxIncrementalFixpointRounds;
- }
-
private:
typedef std::vector<WrapperInfo> WrapperCache;
EmbedderHeapTracer* remote_tracer_;
WrapperCache cached_wrappers_to_trace_;
- size_t num_v8_marking_deque_was_empty_;
};
} // namespace internal
« no previous file with comments | « no previous file | src/heap/embedder-tracing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698