Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2592383002: Revert of [regexp] Remove IsRegExp intrinsic (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Remove IsRegExp intrinsic (patchset #1 id:1 of https://codereview.chromium.org/2591923003/ ) Reason for revert: speculative revert: https://codereview.chromium.org/2596013002/ Original issue's description: > [regexp] Remove IsRegExp intrinsic > > The two remaining uses of this intrinsic in debug.js and mirrors.js now > simply rely on the runtime function. > > BUG=v8:5339 > > Review-Url: https://codereview.chromium.org/2591923003 > Cr-Commit-Position: refs/heads/master@{#41892} > Committed: https://chromium.googlesource.com/v8/v8/+/c9cb94a06fa7a863d24dd6760b66cecd55748abf TBR=bmeurer@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339 Review-Url: https://codereview.chromium.org/2592383002 Cr-Commit-Position: refs/heads/master@{#41915} Committed: https://chromium.googlesource.com/v8/v8/+/1e994192d6e5e441f6dc14596f25c7273651fba8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -2 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/debug/debug.js View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/mjsunit/constant-fold-control-instructions.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of [regexp] Remove IsRegExp intrinsic
4 years ago (2016-12-22 09:39:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592383002/1
4 years ago (2016-12-22 09:39:25 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-22 09:39:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1e994192d6e5e441f6dc14596f25c727365...

Powered by Google App Engine
This is Rietveld 408576698