Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2591923003: [regexp] Remove IsRegExp intrinsic (Closed)

Created:
4 years ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Remove IsRegExp intrinsic The two remaining uses of this intrinsic in debug.js and mirrors.js now simply rely on the runtime function. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2591923003 Cr-Original-Commit-Position: refs/heads/master@{#41892} Committed: https://chromium.googlesource.com/v8/v8/+/c9cb94a06fa7a863d24dd6760b66cecd55748abf Review-Url: https://codereview.chromium.org/2591923003 Cr-Commit-Position: refs/heads/master@{#42128} Committed: https://chromium.googlesource.com/v8/v8/+/9e65ecd957e62a1477d21742c61014fd0421521f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -289 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/debug/debug.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 1 chunk +0 lines, -21 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/js/macros.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M test/mjsunit/constant-fold-control-instructions.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 33 (20 generated)
jgruber
4 years ago (2016-12-21 13:46:56 UTC) #4
jgruber
4 years ago (2016-12-21 13:46:58 UTC) #5
Yang
On 2016/12/21 13:46:58, jgruber wrote: awesome. lgtm.
4 years ago (2016-12-21 13:49:29 UTC) #6
Benedikt Meurer
W00t. LGTM!
4 years ago (2016-12-21 13:50:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591923003/1
4 years ago (2016-12-21 13:53:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/c9cb94a06fa7a863d24dd6760b66cecd55748abf
4 years ago (2016-12-21 13:55:33 UTC) #14
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2592383002/ by hablich@chromium.org. ...
4 years ago (2016-12-22 09:39:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591923003/1
3 years, 11 months ago (2017-01-09 08:14:59 UTC) #18
commit-bot: I haz the power
Failed to apply patch for src/crankshaft/hydrogen.h: While running git apply --index -p1; error: patch failed: ...
3 years, 11 months ago (2017-01-09 08:41:05 UTC) #20
jgruber
On 2016/12/22 09:39:15, Hablich (OOO) wrote: > A revert of this CL (patchset #1 id:1) ...
3 years, 11 months ago (2017-01-09 08:45:02 UTC) #23
commit-bot: I haz the power
This CL has an open dependency (Issue 2619753002 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-09 08:56:06 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591923003/20001
3 years, 11 months ago (2017-01-09 09:33:07 UTC) #30
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 09:34:57 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9e65ecd957e62a1477d21742c61014fd042...

Powered by Google App Engine
This is Rietveld 408576698