Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2592253002: Disallow GL_SAMPLES_PASSED as a query target. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, liberato (no reviews please), Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow GL_SAMPLES_PASSED as a query target. This is from desktop OpenGL. It doesn't exist in OpenGL ES. BUG=676140 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5dadf19d180d9cb216c15f890780757cbdc4f35d Cr-Commit-Position: refs/heads/master@{#440313}

Patch Set 1 #

Patch Set 2 : Added unittest. #

Patch Set 3 : Made the unit test actually work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Ken Russell (switch to Gerrit)
PTAL I haven't actually run the new unit test yet. Rebuilding to do so now. ...
4 years ago (2016-12-21 23:03:16 UTC) #3
Ken Russell (switch to Gerrit)
4 years ago (2016-12-21 23:03:53 UTC) #4
Zhenyao Mo
On 2016/12/21 23:03:53, Ken Russell wrote: lgtm
4 years ago (2016-12-21 23:12:37 UTC) #5
Ken Russell (switch to Gerrit)
Unit test is passing now. CQ'ing. BTW, Mo, thanks to you and Kai (and the ...
4 years ago (2016-12-22 00:29:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592253002/40001
4 years ago (2016-12-22 00:29:42 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-22 02:14:36 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 02:17:00 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5dadf19d180d9cb216c15f890780757cbdc4f35d
Cr-Commit-Position: refs/heads/master@{#440313}

Powered by Google App Engine
This is Rietveld 408576698