gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 2592253002: Disallow GL_SAMPLES_PASSED as a query target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2592253002: Disallow GL_SAMPLES_PASSED as a query target. (Closed)

Patch Set: Made the unit test actually work. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index a9e5d3cca66e2cf94e7a502e326aa5882db161bf..9c7688272dba7e309e0184c7b8cd7af7bcee657a 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -15876,7 +15876,6 @@ error::Error GLES2DecoderImpl::HandleBeginQueryEXT(

return error::kNoError;

}

break;

- case GL_SAMPLES_PASSED:

case GL_ANY_SAMPLES_PASSED:

case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:

if (!features().occlusion_query_boolean) {

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc » ('j') | no next file with comments »