Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2592123003: Update TaskTraits in password_manager_util_win.cc. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
vabr (Chromium), gab
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TaskTraits in password_manager_util_win.cc. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org BUG=675660 Committed: https://crrev.com/6c4ec8707e0b0ce8f364bec09584e032c4407349 Cr-Commit-Position: refs/heads/master@{#440138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/password_manager/password_manager_util_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
fdoray
PTAL
4 years ago (2016-12-21 16:09:05 UTC) #4
gab
lgtm
4 years ago (2016-12-21 16:12:22 UTC) #5
vabr (Chromium)
LGTM, thanks!
4 years ago (2016-12-21 16:38:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592123003/1
4 years ago (2016-12-21 17:23:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 17:29:45 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 17:31:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c4ec8707e0b0ce8f364bec09584e032c4407349
Cr-Commit-Position: refs/heads/master@{#440138}

Powered by Google App Engine
This is Rietveld 408576698