Chromium Code Reviews
DescriptionUpdate TaskTraits in password_manager_util_win.cc.
The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing
.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).
.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.
R=gab@chromium.org
BUG=675660
Committed: https://crrev.com/6c4ec8707e0b0ce8f364bec09584e032c4407349
Cr-Commit-Position: refs/heads/master@{#440138}
Patch Set 1 #
Messages
Total messages: 15 (9 generated)
|
|||||||||||||||||||