Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5196)

Unified Diff: chrome/browser/password_manager/password_manager_util_win.cc

Issue 2592123003: Update TaskTraits in password_manager_util_win.cc. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager_util_win.cc
diff --git a/chrome/browser/password_manager/password_manager_util_win.cc b/chrome/browser/password_manager/password_manager_util_win.cc
index 7071a4f4db1c9c53f73c48086ec8b3364091d09b..43ceb84e8dcaafa7d647591faabf2ca981d1d17f 100644
--- a/chrome/browser/password_manager/password_manager_util_win.cc
+++ b/chrome/browser/password_manager/password_manager_util_win.cc
@@ -207,10 +207,11 @@ void GetOsPasswordStatus() {
new OsPasswordStatus(PASSWORD_STATUS_UNKNOWN));
PasswordCheckPrefs* prefs_weak = prefs.get();
OsPasswordStatus* status_weak = status.get();
+ // This task calls ::LogonUser(), hence MayBlock().
base::PostTaskWithTraitsAndReply(
FROM_HERE, base::TaskTraits()
.WithPriority(base::TaskPriority::BACKGROUND)
- .WithWait(),
+ .MayBlock(),
base::Bind(&GetOsPasswordStatusInternal, prefs_weak, status_weak),
base::Bind(&ReplyOsPasswordStatus, base::Passed(&prefs),
base::Passed(&status)));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698