Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2591963004: Transform RefCountedDeleteOnMessageLoop to RefCountedDeleteOnSequence. (Closed)

Created:
4 years ago by fdoray
Modified:
3 years, 12 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gavinp+memory_chromium.org, chromium-apps-reviews_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, android-webview-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Transform RefCountedDeleteOnMessageLoop to RefCountedDeleteOnSequence. RefCountedDeleteOnSequence behaves the same way as RefCountedDeleteOnMessageLoop when used with a SingleThreadTaskRunner. However, it also supports SequencedTaskRunner. TBR=boliu@chromium.org,mathp@chromium.org,rogerta@chromium.org,pkasting@chromium.org,clamy@chromium.org,rockot@chromium.org BUG=675631 Committed: https://crrev.com/33d98b6545da7591c58a9f95c401c9bedf826c43 Cr-Commit-Position: refs/heads/master@{#440627}

Patch Set 1 #

Patch Set 2 : fix build error #

Total comments: 2

Patch Set 3 : similarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -141 lines) Patch
M android_webview/browser/net/aw_cookie_store_wrapper.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
D base/memory/ref_counted_delete_on_message_loop.h View 1 chunk +0 lines, -73 lines 0 comments Download
A + base/memory/ref_counted_delete_on_sequence.h View 1 2 1 chunk +25 lines, -28 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/signin/core/browser/webdata/token_web_data.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/webdata/common/web_data_service_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/webdata/common/web_data_service_base.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/webdata/common/web_database_backend.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/webdata/common/web_database_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/webdata/common/web_database_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_io_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_io_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/io_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
fdoray
PTAL
4 years ago (2016-12-22 14:25:16 UTC) #10
gab
lgtm https://codereview.chromium.org/2591963004/diff/20001/base/memory/ref_counted_delete_on_sequence.h File base/memory/ref_counted_delete_on_sequence.h (right): https://codereview.chromium.org/2591963004/diff/20001/base/memory/ref_counted_delete_on_sequence.h#newcode1 base/memory/ref_counted_delete_on_sequence.h:1: // Copyright 2013 The Chromium Authors. All rights ...
4 years ago (2016-12-22 20:32:28 UTC) #11
fdoray
https://codereview.chromium.org/2591963004/diff/20001/base/memory/ref_counted_delete_on_sequence.h File base/memory/ref_counted_delete_on_sequence.h (right): https://codereview.chromium.org/2591963004/diff/20001/base/memory/ref_counted_delete_on_sequence.h#newcode1 base/memory/ref_counted_delete_on_sequence.h:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
3 years, 12 months ago (2016-12-23 12:49:31 UTC) #12
fdoray
TBR owners of affected call sites
3 years, 12 months ago (2016-12-23 12:52:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591963004/40001
3 years, 12 months ago (2016-12-23 12:53:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 12 months ago (2016-12-23 14:03:21 UTC) #21
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 14:07:18 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/33d98b6545da7591c58a9f95c401c9bedf826c43
Cr-Commit-Position: refs/heads/master@{#440627}

Powered by Google App Engine
This is Rietveld 408576698