Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: components/webdata/common/web_data_service_base.h

Issue 2591963004: Transform RefCountedDeleteOnMessageLoop to RefCountedDeleteOnSequence. (Closed)
Patch Set: similarity Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_ 5 #ifndef COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_
6 #define COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_ 6 #define COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/memory/ref_counted_delete_on_message_loop.h" 12 #include "base/memory/ref_counted_delete_on_sequence.h"
13 #include "components/webdata/common/webdata_export.h" 13 #include "components/webdata/common/webdata_export.h"
14 #include "sql/init_status.h" 14 #include "sql/init_status.h"
15 15
16 class WebDatabase; 16 class WebDatabase;
17 class WebDatabaseService; 17 class WebDatabaseService;
18 18
19 namespace base { 19 namespace base {
20 // TODO(skyostil): Migrate to SingleThreadTaskRunner (crbug.com/465354). 20 // TODO(skyostil): Migrate to SingleThreadTaskRunner (crbug.com/465354).
21 class SingleThreadTaskRunner; 21 class SingleThreadTaskRunner;
22 } 22 }
23 23
24 // Base for WebDataService class hierarchy. 24 // Base for WebDataService class hierarchy.
25 // WebDataServiceBase is destroyed on the UI thread. 25 // WebDataServiceBase is destroyed on the UI thread.
26 class WEBDATA_EXPORT WebDataServiceBase 26 class WEBDATA_EXPORT WebDataServiceBase
27 : public base::RefCountedDeleteOnMessageLoop<WebDataServiceBase> { 27 : public base::RefCountedDeleteOnSequence<WebDataServiceBase> {
28 public: 28 public:
29 // All requests return an opaque handle of the following type. 29 // All requests return an opaque handle of the following type.
30 typedef int Handle; 30 typedef int Handle;
31 31
32 // Users of this class may provide a callback to handle errors 32 // Users of this class may provide a callback to handle errors
33 // (e.g. by showing a UI). The callback is called only on error, and 33 // (e.g. by showing a UI). The callback is called only on error, and
34 // takes a single parameter, the sql::InitStatus value from trying 34 // takes a single parameter, the sql::InitStatus value from trying
35 // to open the database. 35 // to open the database.
36 // TODO(joi): Should we combine this with WebDatabaseService::InitCallback? 36 // TODO(joi): Should we combine this with WebDatabaseService::InitCallback?
37 typedef base::Callback<void(sql::InitStatus, const std::string&)> 37 typedef base::Callback<void(sql::InitStatus, const std::string&)>
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 // Returns true if the database load has completetd successfully, and 77 // Returns true if the database load has completetd successfully, and
78 // ShutdownOnUIThread has not yet been called. 78 // ShutdownOnUIThread has not yet been called.
79 virtual bool IsDatabaseLoaded(); 79 virtual bool IsDatabaseLoaded();
80 80
81 // Returns a pointer to the DB (used by SyncableServices). May return NULL if 81 // Returns a pointer to the DB (used by SyncableServices). May return NULL if
82 // the database is not loaded or otherwise unavailable. Must be called on 82 // the database is not loaded or otherwise unavailable. Must be called on
83 // DBThread. 83 // DBThread.
84 virtual WebDatabase* GetDatabase(); 84 virtual WebDatabase* GetDatabase();
85 85
86 protected: 86 protected:
87 friend class base::RefCountedDeleteOnMessageLoop<WebDataServiceBase>; 87 friend class base::RefCountedDeleteOnSequence<WebDataServiceBase>;
88 friend class base::DeleteHelper<WebDataServiceBase>; 88 friend class base::DeleteHelper<WebDataServiceBase>;
89 89
90 virtual ~WebDataServiceBase(); 90 virtual ~WebDataServiceBase();
91 91
92 // Our database service. 92 // Our database service.
93 scoped_refptr<WebDatabaseService> wdbs_; 93 scoped_refptr<WebDatabaseService> wdbs_;
94 94
95 private: 95 private:
96 ProfileErrorCallback profile_error_callback_; 96 ProfileErrorCallback profile_error_callback_;
97 97
98 DISALLOW_COPY_AND_ASSIGN(WebDataServiceBase); 98 DISALLOW_COPY_AND_ASSIGN(WebDataServiceBase);
99 }; 99 };
100 100
101 #endif // COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_ 101 #endif // COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_
OLDNEW
« no previous file with comments | « components/signin/core/browser/webdata/token_web_data.cc ('k') | components/webdata/common/web_data_service_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698