Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2591853002:
Ship String.prototype.pad{Start,End} (Closed)
DescriptionShip String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2591853002
Cr-Original-Commit-Position: refs/heads/master@{#41873}
Committed: https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332bb01c
Review-Url: https://codereview.chromium.org/2591853002
Cr-Commit-Position: refs/heads/master@{#41877}
Committed: https://chromium.googlesource.com/v8/v8/+/ba357cadf2b58abf312c16b754c8961fc0c3c0cd
Patch Set 1 #Patch Set 2 : Rebased #Messages
Total messages: 24 (16 generated)
Description was changed from
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
==========
to
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
adamk@chromium.org changed reviewers: + caitp@igalia.com
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14591)
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/20 19:32:11, adamk wrote: Lgtm
The CQ bit was unchecked by adamk@chromium.org
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482263595478480,
"parent_rev": "cc48d2b1d87f4cab501a66eea2083f1c64d5007b", "commit_rev":
"07277202cf136e70c147e2f000e48964332bb01c"}
Message was sent while issue was closed.
Description was changed from
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
to
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2591853002
Cr-Commit-Position: refs/heads/master@{#41873}
Committed:
https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2588423003/ by adamk@chromium.org. The reason for reverting is: Fails on gcstress bot (mjsunit/regress/regress-trap-allocation-memento.js).
Message was sent while issue was closed.
On 2016/12/20 21:34:44, adamk wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2588423003/ by mailto:adamk@chromium.org. > > The reason for reverting is: Fails on gcstress bot > (mjsunit/regress/regress-trap-allocation-memento.js). Okay, disabled that test on gc stress in https://codereview.chromium.org/2597543002
Message was sent while issue was closed.
Description was changed from
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2591853002
Cr-Commit-Position: refs/heads/master@{#41873}
Committed:
https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332...
==========
to
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2591853002
Cr-Commit-Position: refs/heads/master@{#41873}
Committed:
https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332...
==========
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482275415013290,
"parent_rev": "75586d3d9ba33ece2f0311911aa0868e4477ef84", "commit_rev":
"ba357cadf2b58abf312c16b754c8961fc0c3c0cd"}
Message was sent while issue was closed.
Description was changed from
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2591853002
Cr-Commit-Position: refs/heads/master@{#41873}
Committed:
https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332...
==========
to
==========
Ship String.prototype.pad{Start,End}
BUG=v8:4954
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2591853002
Cr-Original-Commit-Position: refs/heads/master@{#41873}
Committed:
https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332...
Review-Url: https://codereview.chromium.org/2591853002
Cr-Commit-Position: refs/heads/master@{#41877}
Committed:
https://chromium.googlesource.com/v8/v8/+/ba357cadf2b58abf312c16b754c8961fc0c...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/ba357cadf2b58abf312c16b754c8961fc0c... |
