RTCPeerConnection.getStats: Remove selector argument.

RTCPeerConnection.getStats: Remove selector argument.

In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]

[1] Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s
[2] webrtc-stats issue: https://github.com/w3c/webrtc-stats/issues/116

BUG=chromium:627816
Committed: https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082
Cr-Commit-Position: refs/heads/master@{#440073}

[hbos_chromium, 2016-12-20 14:11:22]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 14:11:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2016-12-20 14:14:26]

hbos@chromium.org changed reviewers:
+ guidou@chromium.org

[hbos_chromium, 2016-12-20 14:14:26]

Please take a look, guidou

[Guido Urdaneta, 2016-12-20 15:38:51]

lgtm % nit

https://codereview.chromium.org/2591763002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
(right):

https://codereview.chromium.org/2591763002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl:110:
[CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats]
Promise<RTCStatsReport> getStats();
nit: Add a TODO with info about the selector argument.

[hbos_chromium, 2016-12-20 15:42:09]

hbos@chromium.org changed reviewers:
+ hta@chromium.org

[hbos_chromium, 2016-12-20 15:42:10]

+hta FYI

[commit-bot: I haz the power, 2016-12-20 15:52:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 15:52:10]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2016-12-21 10:52:27]

https://codereview.chromium.org/2591763002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
(right):

https://codereview.chromium.org/2591763002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl:110:
[CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats]
Promise<RTCStatsReport> getStats();
On 2016/12/20 15:38:51, Guido Urdaneta wrote:
> nit: Add a TODO with info about the selector argument.

Done.

[hbos_chromium, 2016-12-21 10:52:35]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-12-21 10:52:35]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org
Link to the patchset: https://codereview.chromium.org/2591763002/#ps20001
(title: "Added TODO")

[commit-bot: I haz the power, 2016-12-21 10:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 12:25:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482317555069000,
"parent_rev": "4b924fd77dfbe2e9d79d591da2e05096d1ad2cbe", "commit_rev":
"8ee72a3ca28823ca7f1e2b8f8fd7bf862720644a"}

[commit-bot: I haz the power, 2016-12-21 12:25:38]

Description was changed from

==========
RTCPeerConnection.getStats: Remove selector argument.

In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]

[1] Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s
[2] webrtc-stats issue: https://github.com/w3c/webrtc-stats/issues/116

BUG=chromium:627816
==========

to

==========
RTCPeerConnection.getStats: Remove selector argument.

In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]

[1] Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s
[2] webrtc-stats issue: https://github.com/w3c/webrtc-stats/issues/116

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2591763002
==========

[commit-bot: I haz the power, 2016-12-21 12:25:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 12:28:21]

Description was changed from

==========
RTCPeerConnection.getStats: Remove selector argument.

In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]

[1] Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s
[2] webrtc-stats issue: https://github.com/w3c/webrtc-stats/issues/116

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2591763002
==========

to

==========
RTCPeerConnection.getStats: Remove selector argument.

In preparation for shipping[1] the promise-based getStats, the selector
argument is removed. It was ignored by our implementation. If we want it
we can add it as a separate feature launch, but there is an ongoing
discussion about the usefulness of |selector|.[2]

[1] Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s
[2] webrtc-stats issue: https://github.com/w3c/webrtc-stats/issues/116

BUG=chromium:627816

Committed: https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082
Cr-Commit-Position: refs/heads/master@{#440073}
==========

[commit-bot: I haz the power, 2016-12-21 12:28:22]

Patchset 2 (id:??) landed as
https://crrev.com/381153f75c73bd665fefd04e5dd9de379a40b082
Cr-Commit-Position: refs/heads/master@{#440073}