Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2591763002: RTCPeerConnection.getStats: Remove selector argument. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 [CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallb ack successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Di ctionary mediaConstraints); 100 [CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallb ack successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Di ctionary mediaConstraints);
101 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description, VoidCallback successCallback, [Default=Undefined] optional R TCPeerConnectionErrorCallback failureCallback); 101 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description, VoidCallback successCallback, [Default=Undefined] optional R TCPeerConnectionErrorCallback failureCallback);
102 // TODO(guidou): The failureCallback argument should be non-optional. 102 // TODO(guidou): The failureCallback argument should be non-optional.
103 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback); 103 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);
104 [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Pro mise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, V oidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback); 104 [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Pro mise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, V oidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback);
105 105
106 // TODO(guidou): The selector argument should the first (nullable, 106 // TODO(guidou): The selector argument should the first (nullable,
107 // non-optional) argument, and there should be a third failureCallback 107 // non-optional) argument, and there should be a third failureCallback
108 // argument. 108 // argument.
109 [CallWith=ScriptState, LegacyInterfaceTypeChecking] Promise<void> getStats(R TCStatsCallback successCallback, optional MediaStreamTrack? selector); 109 [CallWith=ScriptState, LegacyInterfaceTypeChecking] Promise<void> getStats(R TCStatsCallback successCallback, optional MediaStreamTrack? selector);
110 [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise< RTCStatsReport> getStats(optional MediaStreamTrack? selector); 110 [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise< RTCStatsReport> getStats();
Guido Urdaneta 2016/12/20 15:38:51 nit: Add a TODO with info about the selector argum
hbos_chromium 2016/12/21 10:52:27 Done.
111 111
112 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api 112 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
113 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString] 113 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString]
114 // and be non-nullable. 114 // and be non-nullable.
115 [CallWith=ExecutionContext, RaisesException] RTCDataChannel createDataChanne l(DOMString? label, optional Dictionary options); 115 [CallWith=ExecutionContext, RaisesException] RTCDataChannel createDataChanne l(DOMString? label, optional Dictionary options);
116 attribute EventHandler ondatachannel; 116 attribute EventHandler ondatachannel;
117 117
118 // Certificate management 118 // Certificate management
119 // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt 119 // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt
120 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm); 120 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm);
121 121
122 // Non-standard or removed from the spec: 122 // Non-standard or removed from the spec:
123 [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optiona l RTCConfiguration configuration, optional Dictionary mediaConstraints); 123 [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optiona l RTCConfiguration configuration, optional Dictionary mediaConstraints);
124 [Measure] sequence<MediaStream> getLocalStreams(); 124 [Measure] sequence<MediaStream> getLocalStreams();
125 [Measure] sequence<MediaStream> getRemoteStreams(); 125 [Measure] sequence<MediaStream> getRemoteStreams();
126 [Measure] MediaStream getStreamById(DOMString streamId); 126 [Measure] MediaStream getStreamById(DOMString streamId);
127 [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaSt ream? stream, optional Dictionary mediaConstraints); 127 [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaSt ream? stream, optional Dictionary mediaConstraints);
128 [Measure, RaisesException] void removeStream(MediaStream? stream); 128 [Measure, RaisesException] void removeStream(MediaStream? stream);
129 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack); 129 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack);
130 attribute EventHandler onaddstream; 130 attribute EventHandler onaddstream;
131 attribute EventHandler onremovestream; 131 attribute EventHandler onremovestream;
132 }; 132 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698