S390 [Crankshaft]: Use LoadPositive for MathAbs

S390 [Crankshaft]: Use LoadPositive for MathAbs

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com

BUG=

Review-Url: https://codereview.chromium.org/2591643005
Cr-Commit-Position: refs/heads/master@{#41906}
Committed: https://chromium.googlesource.com/v8/v8/+/c46f98bcedb600538e9b41ad3179ebaa724e86c4

[Sampson, 2016-12-21 16:35:07]

Please take a look.

[john.yan, 2016-12-21 17:37:40]

https://codereview.chromium.org/2591643005/diff/1/src/crankshaft/s390/lithium...
File src/crankshaft/s390/lithium-codegen-s390.cc (right):

https://codereview.chromium.org/2591643005/diff/1/src/crankshaft/s390/lithium...
src/crankshaft/s390/lithium-codegen-s390.cc:3399: __ LoadPositive32(result,
input);
I think it's better to use lpgfr here.

https://codereview.chromium.org/2591643005/diff/1/src/s390/simulator-s390.cc
File src/s390/simulator-s390.cc (right):

https://codereview.chromium.org/2591643005/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:10018: int64_t r1_val = static_cast<int64_t>(r2_val <
0) ? -r2_val : r2_val;
why static_cast<int64_t>(r2_val < 0)?

[john.yan, 2016-12-21 21:03:52]

lgtm

https://codereview.chromium.org/2591643005/diff/20001/src/crankshaft/s390/lit...
File src/crankshaft/s390/lithium-codegen-s390.cc (right):

https://codereview.chromium.org/2591643005/diff/20001/src/crankshaft/s390/lit...
src/crankshaft/s390/lithium-codegen-s390.cc:3399: __ LoadPositive32(result,
input);
maybe more lgfr to here instead of putting in MacroAssembler?

[john.yan, 2016-12-21 21:03:54]

lgtm

[john.yan, 2016-12-21 21:03:55]

lgtm

[john.yan, 2016-12-21 21:03:56]

lgtm

[Sampson, 2016-12-21 22:12:01]

The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 22:12:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:39:53]

Dry run: This issue passed the CQ dry run.

[Sampson, 2016-12-22 00:27:07]

The CQ bit was checked by sampsong@ca.ibm.com

[commit-bot: I haz the power, 2016-12-22 00:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:29:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482366427629760,
"parent_rev": "c8ce0cf99eea5aedc45ca899fcb5d1c7764c2cb8", "commit_rev":
"c46f98bcedb600538e9b41ad3179ebaa724e86c4"}

[commit-bot: I haz the power, 2016-12-22 00:29:37]

Description was changed from

==========
S390 [Crankshaft]: Use LoadPositive for MathAbs

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
bjaideep@ca.ibm.com

BUG=
==========

to

==========
S390 [Crankshaft]: Use LoadPositive for MathAbs

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
bjaideep@ca.ibm.com

BUG=

Review-Url: https://codereview.chromium.org/2591643005
Cr-Commit-Position: refs/heads/master@{#41906}
Committed:
https://chromium.googlesource.com/v8/v8/+/c46f98bcedb600538e9b41ad3179ebaa724...
==========

[commit-bot: I haz the power, 2016-12-22 00:29:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c46f98bcedb600538e9b41ad3179ebaa724...