Add permission prompt UI experiments to variations testing.

Add permission prompt UI experiments to variations testing.

BUG=632269
Committed: https://crrev.com/70bb299200ff08b9fc349124e1f84eff4a25135d
Cr-Commit-Position: refs/heads/master@{#439908}

[dominickn, 2016-12-19 23:37:36]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 23:38:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-12-19 23:38:48]

Description was changed from

==========
Add permission prompt UI experiments to variations testing.

BUG=632269
==========

to

==========
Add permission prompt UI experiments to variations testing.

BUG=632269
==========

[dominickn, 2016-12-19 23:38:48]

dominickn@chromium.org changed reviewers:
+ isherman@chromium.org

[dominickn, 2016-12-19 23:38:58]

PTAL, thanks.

[commit-bot: I haz the power, 2016-12-20 01:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:00:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ilya Sherman, 2016-12-20 01:19:54]

LGTM

https://codereview.chromium.org/2591523003/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2591523003/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:1441: }
Note that only the first of the listed experiments will be tested, and should
therefore be the experiment that you expect to launch.  Listing the other
experiments is optional.

[dominickn, 2016-12-20 01:32:16]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:32:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 02:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 02:50:38]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominickn, 2016-12-20 02:55:15]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2016-12-20 02:55:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 04:18:05]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominickn, 2016-12-20 05:37:12]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 05:37:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 06:37:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 06:37:15]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-12-20 06:54:20]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2016-12-20 06:54:21]

dfalcantara: PTAL, thanks. I had to add disable-features flags to a number of
the permission prompt infobar experiments to make sure that when tests are run
with the global enable-features flag, they still pass.

https://codereview.chromium.org/2591523003/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2591523003/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:1441: }
On 2016/12/20 01:19:54, Ilya Sherman wrote:
> Note that only the first of the listed experiments will be tested, and should
> therefore be the experiment that you expect to launch.  Listing the other
> experiments is optional.

Thanks. The first experiment is most likely to launch, but we will see what the
1% experiment on stable tells us before proceeding.

[gone, 2016-12-20 18:59:16]

lgtm

[gone, 2016-12-20 18:59:16]

lgtm

lgtm

[dominickn, 2016-12-20 22:55:08]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-12-20 22:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2591523003/#ps20001
(title: "Add feature flag overrides to ensure tests pass")

[commit-bot: I haz the power, 2016-12-20 22:55:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:04:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482274508230190,
"parent_rev": "67b8c751915b1f4b71c0e2a2cb690558929941cf", "commit_rev":
"fbdbe796ca884843baf674058809e96c8edf11a0"}

[commit-bot: I haz the power, 2016-12-20 23:05:14]

Description was changed from

==========
Add permission prompt UI experiments to variations testing.

BUG=632269
==========

to

==========
Add permission prompt UI experiments to variations testing.

BUG=632269

Review-Url: https://codereview.chromium.org/2591523003
==========

[commit-bot: I haz the power, 2016-12-20 23:05:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 23:07:42]

Description was changed from

==========
Add permission prompt UI experiments to variations testing.

BUG=632269

Review-Url: https://codereview.chromium.org/2591523003
==========

to

==========
Add permission prompt UI experiments to variations testing.

BUG=632269

Committed: https://crrev.com/70bb299200ff08b9fc349124e1f84eff4a25135d
Cr-Commit-Position: refs/heads/master@{#439908}
==========

[commit-bot: I haz the power, 2016-12-20 23:07:43]

Patchset 2 (id:??) landed as
https://crrev.com/70bb299200ff08b9fc349124e1f84eff4a25135d
Cr-Commit-Position: refs/heads/master@{#439908}