chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java - Issue 2591523003: Add permission prompt UI experiments to variations testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java

Issue 2591523003: Add permission prompt UI experiments to variations testing. (Closed)

Patch Set: Add feature flag overrides to ensure tests pass Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java ('k') | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java

index 3da468ce88b7b6fad011fc453bb2434f0d623de9..8b661f66167a4c1452140cf6aa795f4cf7878005 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java

@@ -18,6 +18,7 @@ import android.util.Pair;

import org.chromium.base.ThreadUtils;

import org.chromium.base.library_loader.ProcessInitException;

import org.chromium.base.test.util.CallbackHelper;

+import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.RetryOnFailure;

import org.chromium.chrome.browser.infobar.InfoBar;

@@ -116,6 +117,7 @@ public class PushMessagingTest

@MediumTest

@Feature({"Browser", "PushMessaging"})

+ @CommandLineFlags.Add("disable-features=ModalPermissionPrompts")

public void testPushPermissionDenied() throws InterruptedException, TimeoutException {

// Notifications permission should initially be prompt.

assertEquals("\"default\"", runScriptBlocking("Notification.permission"));

@@ -166,6 +168,7 @@ public class PushMessagingTest

@MediumTest

@Feature({"Browser", "PushMessaging"})

+ @CommandLineFlags.Add("disable-features=ModalPermissionPrompts")

public void testPushPermissionGranted() throws InterruptedException, TimeoutException {

// Notifications permission should initially be prompt.

assertEquals("\"default\"", runScriptBlocking("Notification.permission"));