Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2591173002: Disable CopyTextureCHROMIUM gl_tests for RGB5_A1 format (Closed)

Created:
4 years ago by qiankun
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable CopyTextureCHROMIUM gl_tests for RGB5_A1 format RGB5_A1 is not color-renderable on NVIDIA Mac. This makes related gl_tests fail on NVIDIA Mac. Disable it before it is fixed in NVIDIA Mac driver or we make a workaround for it. BUG=612542, 676209 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/43c62e6cae8262c8840b0a801f026233d53c6d5d Cr-Commit-Position: refs/heads/master@{#440120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
qiankun
PTAL
4 years ago (2016-12-21 05:18:08 UTC) #3
Zhenyao Mo
On 2016/12/21 05:18:08, qiankun wrote: > PTAL What about only skipping it on Mac? Using ...
4 years ago (2016-12-21 14:08:30 UTC) #4
Zhenyao Mo
On 2016/12/21 14:08:30, Zhenyao Mo wrote: > On 2016/12/21 05:18:08, qiankun wrote: > > PTAL ...
4 years ago (2016-12-21 14:09:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591173002/1
4 years ago (2016-12-21 16:10:44 UTC) #7
Ken Russell (switch to Gerrit)
CQ'ing this to get the bots green again. We can refine the fix later. LGTM ...
4 years ago (2016-12-21 16:10:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 16:25:35 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43c62e6cae8262c8840b0a801f026233d53c6d5d Cr-Commit-Position: refs/heads/master@{#440120}
4 years ago (2016-12-21 16:28:44 UTC) #13
qiankun
4 years ago (2016-12-22 07:09:33 UTC) #14
Message was sent while issue was closed.
On 2016/12/21 16:10:45, Ken Russell wrote:
> CQ'ing this to get the bots green again. We can refine the fix later. LGTM but
> let's follow up to make the fix more narrow.

Thanks for merging. I will limit it to Mac only when I update the file again.

Powered by Google App Engine
This is Rietveld 408576698