Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc

Issue 2591173002: Disable CopyTextureCHROMIUM gl_tests for RGB5_A1 format (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc b/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
index 5d6ace6b587fa862c3261f10c529b59e7b7dd782..1c005eba69dfdc604697660e8cc1a057288125a3 100644
--- a/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
+++ b/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
@@ -295,6 +295,12 @@ class GLCopyTextureCHROMIUMES3Test : public GLCopyTextureCHROMIUMTest {
DCHECK(!ShouldSkipTest());
return !gl_.decoder()->GetFeatureInfo()->feature_flags().ext_srgb;
}
+
+ // RGB5_A1 is not color-renderable on NVIDIA Mac, see crbug.com/676209.
+ bool ShouldSkipRGB5_A1() const {
+ DCHECK(!ShouldSkipTest());
+ return true;
+ }
};
INSTANTIATE_TEST_CASE_P(CopyType,
@@ -425,6 +431,8 @@ TEST_P(GLCopyTextureCHROMIUMES3Test, FormatCombinations) {
dest_format_type.internal_format == GL_SRGB_ALPHA_EXT) &&
ShouldSkipSRGBEXT())
continue;
+ if (dest_format_type.internal_format == GL_RGB5_A1 && ShouldSkipRGB5_A1())
+ continue;
const GLsizei kWidth = 8, kHeight = 8;
const int src_channel_count = gles2::GLES2Util::ElementsPerGroup(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698