Rename |tab_contents_id| to |render_view_routing_id|.

Rename |tab_contents_id| to |render_view_routing_id| in external protocol handler code.

|tab_contents_id| is a misleading, confusing, and inappropriate name.

This should not change the functionality of the code, only readability.

BUG=668289
Committed: https://crrev.com/058da9559dd68cd67cf8bbf291a2cfb8a7e55ec1
Cr-Commit-Position: refs/heads/master@{#440228}

[davidsac (gone - try alexmos), 2016-12-21 02:09:25]

The CQ bit was checked by davidsac@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 02:09:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidsac (gone - try alexmos), 2016-12-21 02:12:38]

Description was changed from

==========
Rename |tab_contents_id| to |render_view_routing_id|.

BUG=668289
==========

to

==========
Rename |tab_contents_id| to |render_view_routing_id| in external protocol
handler code.

|tab_contents_id| is a misleading, confusing, and inappropriate name.

This should not change the functionality of the code, only readability.

BUG=668289
==========

[commit-bot: I haz the power, 2016-12-21 02:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:55:21]

Dry run: This issue passed the CQ dry run.

[davidsac (gone - try alexmos), 2016-12-21 19:35:38]

davidsac@chromium.org changed reviewers:
+ nick@chromium.org

[davidsac (gone - try alexmos), 2016-12-21 19:35:39]

Hi Nick,

Will you please review this CL?

As requested, all occurences of |tab_contents_id| in the external protocol
handler code have been renamed to |render_view_routing_id|.

Similarly, all other calls of tab_util::GetWebContentsById have been verified to
use a clear enough name for the second parameter, render_view_id, when being
called.

[ncarter (slow), 2016-12-21 19:42:59]

lgtm

[davidsac (gone - try alexmos), 2016-12-21 21:16:35]

davidsac@chromium.org changed reviewers:
+ alexmos@chromium.org, meacer@chromium.org, msw@chromium.org

[davidsac (gone - try alexmos), 2016-12-21 21:16:36]

Hi,

meacer, could you please review the following changelist for OWNER approval for
chrome/browser/external_protocol?

msw, could you please review the following changelist for OWNER approval for
chrome/browser/ui?

[msw, 2016-12-21 21:25:20]

lgtm

[meacer, 2016-12-21 21:29:36]

Lgtm

[davidsac (gone - try alexmos), 2016-12-21 21:38:35]

The CQ bit was checked by davidsac@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:39:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:46:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482356315871320, "parent_rev":
"0d3764ca187f7da7f4c47b4c4806d5defb44746e", "commit_rev":
"e0bcafb6e8e0108a1f81e1c684fc51824d3cdb5c"}

[commit-bot: I haz the power, 2016-12-21 21:47:13]

Description was changed from

==========
Rename |tab_contents_id| to |render_view_routing_id| in external protocol
handler code.

|tab_contents_id| is a misleading, confusing, and inappropriate name.

This should not change the functionality of the code, only readability.

BUG=668289
==========

to

==========
Rename |tab_contents_id| to |render_view_routing_id| in external protocol
handler code.

|tab_contents_id| is a misleading, confusing, and inappropriate name.

This should not change the functionality of the code, only readability.

BUG=668289

Review-Url: https://codereview.chromium.org/2591143002
==========

[commit-bot: I haz the power, 2016-12-21 21:47:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 21:49:48]

Description was changed from

==========
Rename |tab_contents_id| to |render_view_routing_id| in external protocol
handler code.

|tab_contents_id| is a misleading, confusing, and inappropriate name.

This should not change the functionality of the code, only readability.

BUG=668289

Review-Url: https://codereview.chromium.org/2591143002
==========

to

==========
Rename |tab_contents_id| to |render_view_routing_id| in external protocol
handler code.

|tab_contents_id| is a misleading, confusing, and inappropriate name.

This should not change the functionality of the code, only readability.

BUG=668289

Committed: https://crrev.com/058da9559dd68cd67cf8bbf291a2cfb8a7e55ec1
Cr-Commit-Position: refs/heads/master@{#440228}
==========

[commit-bot: I haz the power, 2016-12-21 21:49:49]

Patchset 1 (id:??) landed as
https://crrev.com/058da9559dd68cd67cf8bbf291a2cfb8a7e55ec1
Cr-Commit-Position: refs/heads/master@{#440228}