Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3730)

Unified Diff: chrome/browser/ui/external_protocol_dialog_delegate.cc

Issue 2591143002: Rename |tab_contents_id| to |render_view_routing_id|. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/external_protocol_dialog_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/external_protocol_dialog_delegate.cc
diff --git a/chrome/browser/ui/external_protocol_dialog_delegate.cc b/chrome/browser/ui/external_protocol_dialog_delegate.cc
index 0116eb0387811373fc32ca2ffafe5b6f576cb371..20c662fd7872ba0a391b06e51ce28d1c877b9fdb 100644
--- a/chrome/browser/ui/external_protocol_dialog_delegate.cc
+++ b/chrome/browser/ui/external_protocol_dialog_delegate.cc
@@ -27,10 +27,10 @@ base::string16 ElideCommandName(const base::string16& command_name) {
ExternalProtocolDialogDelegate::ExternalProtocolDialogDelegate(
const GURL& url,
int render_process_host_id,
- int tab_contents_id)
+ int render_view_routing_id)
: ProtocolDialogDelegate(url),
render_process_host_id_(render_process_host_id),
- tab_contents_id_(tab_contents_id),
+ render_view_routing_id_(render_view_routing_id),
program_name_(shell_integration::GetApplicationNameForProtocol(url)) {}
ExternalProtocolDialogDelegate::~ExternalProtocolDialogDelegate() {
@@ -66,8 +66,8 @@ void ExternalProtocolDialogDelegate::DoAccept(const GURL& url,
ExternalProtocolHandler::DONT_BLOCK);
}
- content::WebContents* web_contents =
- tab_util::GetWebContentsByID(render_process_host_id_, tab_contents_id_);
+ content::WebContents* web_contents = tab_util::GetWebContentsByID(
+ render_process_host_id_, render_view_routing_id_);
ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(url, web_contents);
}
« no previous file with comments | « chrome/browser/ui/external_protocol_dialog_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698