Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2590973002: Fix DCHECK when adding non ASCII bookmark from share extension. (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK when adding non ASCII bookmark from share extension. When adding a bookmark with a non ASCII bookmark, a DCHECK was hit when converting to UTF16. BUG=675981 Committed: https://crrev.com/3f6873e93fd0f0aeb5f2b3bf79765c6620122591 Cr-Commit-Position: refs/heads/master@{#439827}

Patch Set 1 : UTF8ToUTF16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/share_extension/share_extension_item_receiver.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Olivier
4 years ago (2016-12-20 16:18:07 UTC) #3
sdefresne
lgtm
4 years ago (2016-12-20 16:32:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590973002/20001
4 years ago (2016-12-20 16:43:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-20 16:56:47 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 16:58:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f6873e93fd0f0aeb5f2b3bf79765c6620122591
Cr-Commit-Position: refs/heads/master@{#439827}

Powered by Google App Engine
This is Rietveld 408576698