ios/chrome/browser/share_extension/share_extension_item_receiver.mm - Issue 2590973002: Fix DCHECK when adding non ASCII bookmark from share extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/share_extension/share_extension_item_receiver.mm

Issue 2590973002: Fix DCHECK when adding non ASCII bookmark from share extension. (Closed)

Patch Set: UTF8ToUTF16 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/share_extension/share_extension_item_receiver.mm

diff --git a/ios/chrome/browser/share_extension/share_extension_item_receiver.mm b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

index a63334068cb0ad2dd50b566448eaeb6493f4f3b6..58da1e248157e35b9f91f36ee9cf5343c0ecd2de 100644

--- a/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

+++ b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm

@@ -220,7 +220,7 @@ void LogHistogramReceivedItem(ShareExtensionItemReceived type) {

LogHistogramReceivedItem(BOOKMARK_ENTRY);

_bookmarkModel->AddURL(

_bookmarkModel->mobile_node(), 0,

- base::ASCIIToUTF16(entryTitle), entryURL);

+ base::UTF8ToUTF16(entryTitle), entryURL);

}

if (completion) {

web::WebThread::PostTask(web::WebThread::FILE,

« no previous file with comments | « no previous file | no next file » | no next file with comments »