Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2590843002: [tests] Fix test-api for non-optimizing ignition-staging runs (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Fix test-api for non-optimizing ignition-staging runs BUG=v8:5762 Review-Url: https://codereview.chromium.org/2590843002 Cr-Commit-Position: refs/heads/master@{#41852} Committed: https://chromium.googlesource.com/v8/v8/+/73afbaa8c142c9ebcc81019824cd2577cea810cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M test/cctest/test-api.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Leszek Swirski
Michael and Mythri, could you take a look please?
4 years ago (2016-12-20 11:23:58 UTC) #4
mythria
lgtm.
4 years ago (2016-12-20 11:41:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590843002/1
4 years ago (2016-12-20 11:41:55 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 11:47:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/73afbaa8c142c9ebcc81019824cd2577cea...

Powered by Google App Engine
This is Rietveld 408576698