Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: test/cctest/test-api.cc

Issue 2590843002: [tests] Fix test-api for non-optimizing ignition-staging runs (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index ca2c8dea063c4fca55ad398b7e1c8897f15900b6..956fd76161b491c72c0d06aa10ada9d8239f4c64 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -14579,13 +14579,18 @@ void SetFunctionEntryHookTest::RunTest() {
CHECK_EQ(2, CountInvocations(NULL, "bar"));
CHECK_EQ(200, CountInvocations("bar", "foo"));
CHECK_EQ(200, CountInvocations(NULL, "foo"));
- } else {
+ } else if (i::FLAG_crankshaft || i::FLAG_turbo) {
// For ignition we don't see the actual functions being called, instead
- // we see the IterpreterEntryTrampoline at least 102 times
+ // we see the InterpreterEntryTrampoline at least 102 times
// (100 unoptimized calls to foo, and 2 calls to bar).
CHECK_LE(102, CountInvocations(NULL, "InterpreterEntryTrampoline"));
// We should also see the calls to the optimized function foo.
CHECK_EQ(100, CountInvocations(NULL, "foo"));
+ } else {
+ // For ignition without an optimizing compiler, we should only see the
+ // InterpreterEntryTrampoline.
+ // (200 unoptimized calls to foo, and 2 calls to bar).
+ CHECK_LE(202, CountInvocations(NULL, "InterpreterEntryTrampoline"));
}
// Verify that we have an entry hook on some specific stubs.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698