Only add unstaged baseline changes to the git index when rebaselining.

Only add unstaged baseline changes to the git index when rebaselining.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently unstaged changes. There were already methods for listing files that are different from HEAD; that includes staged changes, but I believe we don't want to abort if there are already staged changes to baselines, right? If that's not the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists unstaged changes to baselines. Additionally, when adding files after rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and abort with an error message if there are any.

BUG=662584
Committed: https://crrev.com/99b0e4f3108df37cae3ed6664ca6f14b8a1fd056
Cr-Commit-Position: refs/heads/master@{#440830}

[qyearsley, 2016-12-21 00:06:22]

Description was changed from

==========
rebaseline-cl: Warn when there are unstaged baselines; stage only baselines.

BUG=662584
==========

to

==========
rebaseline-cl: Warn when there are unstaged baselines; stage only baselines.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584
==========

[qyearsley, 2016-12-21 00:06:22]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[qyearsley, 2016-12-21 00:07:42]

Description was changed from

==========
rebaseline-cl: Warn when there are unstaged baselines; stage only baselines.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584
==========

to

==========
Only add unstaged baseline changes to the git index when rebaselining.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584
==========

[qyearsley, 2016-12-21 19:54:30]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:55:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:03:12]

Dry run: This issue passed the CQ dry run.

[wkorman, 2016-12-28 01:45:07]

lgtm

[qyearsley, 2016-12-28 02:48:39]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-12-28 02:48:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 03:48:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482893319972050,
"parent_rev": "8322baea4a28bd73847e4ca1d5ee81d1804383f5", "commit_rev":
"32b637a9dbaf6ce0ba70bde94aeb81cdbdaca2b5"}

[commit-bot: I haz the power, 2016-12-28 03:48:52]

Description was changed from

==========
Only add unstaged baseline changes to the git index when rebaselining.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584
==========

to

==========
Only add unstaged baseline changes to the git index when rebaselining.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584

Review-Url: https://codereview.chromium.org/2590693002
==========

[commit-bot: I haz the power, 2016-12-28 03:48:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:48:31]

Description was changed from

==========
Only add unstaged baseline changes to the git index when rebaselining.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584

Review-Url: https://codereview.chromium.org/2590693002
==========

to

==========
Only add unstaged baseline changes to the git index when rebaselining.

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index
even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently
unstaged changes. There were already methods for listing files that are
different from HEAD; that includes staged changes, but I believe we don't want
to abort if there are already staged changes to baselines, right? If that's not
the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists
unstaged changes to baselines. Additionally, when adding files after
rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and
abort with an error message if there are any.

BUG=662584

Committed: https://crrev.com/99b0e4f3108df37cae3ed6664ca6f14b8a1fd056
Cr-Commit-Position: refs/heads/master@{#440830}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:32]

Patchset 2 (id:??) landed as
https://crrev.com/99b0e4f3108df37cae3ed6664ca6f14b8a1fd056
Cr-Commit-Position: refs/heads/master@{#440830}