third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py - Issue 2590693002: Only add unstaged baseline changes to the git index when rebaselining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

Issue 2590693002: Only add unstaged baseline changes to the git index when rebaselining. (Closed)

Patch Set: rebaseline-cl: Abort if there are unstaged baseline changes. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

index 888ca82c560148158713099c7a006de18e4897b5..b5bb031e149e89caccb44df6bd4660e06b70192c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

@@ -121,6 +121,9 @@ class SCM:

def exists(self, path):

self._subclass_must_implement()

+ def unstaged_changes(self):

+ self._subclass_must_implement()

def changed_files(self, git_commit=None):

self._subclass_must_implement()