Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2590513002: Revert of [Sensors] Align sensor reading updates and 'onchange' notification with rAF. (Closed)

Created:
4 years ago by wjmaclean
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, tdresser, timvolodine, wanming.lin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sensors] Align sensor reading updates and 'onchange' notification with rAF. (patchset #6 id:140001 of https://codereview.chromium.org/2551223003/ ) Reason for revert: Seems like a likely cause for failures on: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sensor%2Faccelerometer.html&testType=webkit_tests Original issue's description: > [Sensors] Align sensor reading updates and 'onchange' notification with rAF. > > For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption. > > Before this change a timers were used and this could unnecessarily drain CPU and battery. > > BUG=668052 > BUG=606766 > > Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb > Cr-Commit-Position: refs/heads/master@{#439467} TBR=reillyg@chromium.org,alexander.shalamov@intel.com,haraken@chromium.org,foolip@chromium.org,mikhail.pozdnyakov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668052 Committed: https://crrev.com/fbf954d48f20330a013b68c5f0eb32094ce29263 Cr-Commit-Position: refs/heads/master@{#439487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -239 lines) Patch
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 8 chunks +44 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 7 chunks +12 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 14 chunks +55 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.h View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
wjmaclean
Created Revert of [Sensors] Align sensor reading updates and 'onchange' notification with rAF.
4 years ago (2016-12-19 16:25:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590513002/1
4 years ago (2016-12-19 16:25:51 UTC) #3
haraken
LGTM
4 years ago (2016-12-19 16:25:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 16:27:03 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-19 16:29:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbf954d48f20330a013b68c5f0eb32094ce29263
Cr-Commit-Position: refs/heads/master@{#439487}

Powered by Google App Engine
This is Rietveld 408576698