Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp

Issue 2590513002: Revert of [Sensors] Align sensor reading updates and 'onchange' notification with rAF. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp
diff --git a/third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp b/third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..14823984f0fd22a101a7a121532f38974390eff3
--- /dev/null
+++ b/third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp
@@ -0,0 +1,85 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/sensor/SensorUpdateNotificationStrategy.h"
+
+#include "device/generic_sensor/public/interfaces/sensor.mojom-blink.h"
+#include "platform/Timer.h"
+#include "wtf/CurrentTime.h"
+
+namespace blink {
+
+// Polls the buffer on signal from platform but not more frequently
+// than the given 'pollingPeriod'.
+class SensorUpdateNotificationStrategyImpl
+ : public SensorUpdateNotificationStrategy {
+ public:
+ SensorUpdateNotificationStrategyImpl(double frequency,
+ std::unique_ptr<Function<void()>> func)
+ : m_pollingPeriod(1 / frequency),
+ m_func(std::move(func)),
+ m_timer(this, &SensorUpdateNotificationStrategyImpl::onTimer),
+ m_lastPollingTimestamp(0.0) {
+ DCHECK_GT(frequency, 0.0);
+ DCHECK(m_func);
+ }
+
+ private:
+ // SensorUpdateNotificationStrategy overrides.
+ void onSensorReadingChanged() override;
+ void cancelPendingNotifications() override;
+
+ void onTimer(TimerBase*);
+ void notifyUpdate();
+
+ double m_pollingPeriod;
+ std::unique_ptr<Function<void()>> m_func;
+ Timer<SensorUpdateNotificationStrategyImpl> m_timer;
+ double m_lastPollingTimestamp;
+};
+
+void SensorUpdateNotificationStrategyImpl::onSensorReadingChanged() {
+ if (m_timer.isActive())
+ return; // Skipping changes if update notification was already sheduled.
+
+ double elapsedTime =
+ WTF::monotonicallyIncreasingTime() - m_lastPollingTimestamp;
+
+ double waitingTime = m_pollingPeriod - elapsedTime;
+ const double minInterval =
+ 1 / device::mojom::blink::SensorConfiguration::kMaxAllowedFrequency;
+
+ // Negative or zero 'waitingTime' means that polling period has elapsed.
+ // We also avoid scheduling if the elapsed time is slightly behind the
+ // polling period.
+ if (waitingTime < minInterval) {
+ notifyUpdate();
+ } else {
+ m_timer.startOneShot(waitingTime, BLINK_FROM_HERE);
+ }
+}
+
+void SensorUpdateNotificationStrategyImpl::cancelPendingNotifications() {
+ m_timer.stop();
+}
+
+void SensorUpdateNotificationStrategyImpl::notifyUpdate() {
+ m_lastPollingTimestamp = WTF::monotonicallyIncreasingTime();
+ (*m_func)();
+}
+
+void SensorUpdateNotificationStrategyImpl::onTimer(TimerBase*) {
+ notifyUpdate();
+}
+
+// static
+std::unique_ptr<SensorUpdateNotificationStrategy>
+SensorUpdateNotificationStrategy::create(
+ double pollingPeriod,
+ std::unique_ptr<Function<void()>> func) {
+ return std::unique_ptr<SensorUpdateNotificationStrategy>(
+ new SensorUpdateNotificationStrategyImpl(pollingPeriod, std::move(func)));
+}
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698