Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Issue 2590483002: Revert of [profiler] fix memory leak for code entries for runtime callstats. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
alph, Camillo Bruni, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [profiler] fix memory leak for code entries for runtime callstats. (patchset #1 id:1 of https://codereview.chromium.org/2586923002/ ) Reason for revert: Looks like the layout tests want these leaks: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/12151 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [profiler] fix memory leak for code entries for runtime callstats. > > Track allocated code entries and delete at the end. This is what we > do in ProfileListener too. > > R=alph@chromium.org, cbruni@chromium.org > BUG=v8:5753 > > Review-Url: https://codereview.chromium.org/2586923002 > Cr-Commit-Position: refs/heads/master@{#41793} > Committed: https://chromium.googlesource.com/v8/v8/+/d0bb789f0358851b6580a274e2b5f2a8f728f44b TBR=cbruni@chromium.org,alph@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5753 Review-Url: https://codereview.chromium.org/2590483002 Cr-Commit-Position: refs/heads/master@{#41806} Committed: https://chromium.googlesource.com/v8/v8/+/2c2d0e5036950b15ca560f13ea0131cb2d52e900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/profiler/profile-generator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [profiler] fix memory leak for code entries for runtime callstats.
4 years ago (2016-12-19 13:49:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590483002/1
4 years ago (2016-12-19 13:49:32 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 13:49:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2c2d0e5036950b15ca560f13ea0131cb2d5...

Powered by Google App Engine
This is Rietveld 408576698