Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2586923002: [profiler] fix memory leak for code entries for runtime callstats. (Closed)

Created:
4 years ago by Yang
Modified:
3 years, 10 months ago
Reviewers:
alph, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] fix memory leak for code entries for runtime callstats. Track allocated code entries and delete at the end. This is what we do in ProfileListener too. R=alph@chromium.org, cbruni@chromium.org BUG=v8:5753 Review-Url: https://codereview.chromium.org/2586923002 Cr-Commit-Position: refs/heads/master@{#41793} Committed: https://chromium.googlesource.com/v8/v8/+/d0bb789f0358851b6580a274e2b5f2a8f728f44b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/profiler/profile-generator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yang
4 years ago (2016-12-19 09:53:30 UTC) #1
Camillo Bruni
lgtm
4 years ago (2016-12-19 10:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586923002/1
4 years ago (2016-12-19 10:44:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/d0bb789f0358851b6580a274e2b5f2a8f728f44b
4 years ago (2016-12-19 10:47:04 UTC) #10
Michael Achenbach
4 years ago (2016-12-19 13:49:22 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2590483002/ by machenbach@chromium.org.

The reason for reverting is: Looks like the layout tests want these leaks:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

See:
https://github.com/v8/v8/wiki/Blink-layout-tests.

Powered by Google App Engine
This is Rietveld 408576698