Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2590433003: Re-enable building both 32 and 64 bit version of the GCP port monitor. (Closed)

Created:
4 years ago by pastarmovj
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable building both 32 and 64 bit version of the GCP port monitor. BUG=629512 TEST=Builds both 32 and 64 bit dlls on a 32bit build system. Committed: https://crrev.com/e536476bf377f0d41c7b4e1514e1ac9180e17ce3 Cr-Commit-Position: refs/heads/master@{#439796}

Patch Set 1 #

Patch Set 2 : Fix some issues with 32/64 bit installation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -14 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 1 chunk +6 lines, -6 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 4 chunks +18 lines, -5 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/BUILD.gn View 1 2 chunks +48 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_dll.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.h View 1 chunk +6 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
pastarmovj
Hi Michael can you please review this CL as well. It is mostly reverting of ...
4 years ago (2016-12-19 16:31:36 UTC) #2
Michael Moss
lgtm
4 years ago (2016-12-19 17:07:33 UTC) #5
pastarmovj
Hi Jochen, can you please stamp the change to src/BUILD.gn. Thanks, Julian
4 years ago (2016-12-20 11:56:11 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-20 12:15:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590433003/40001
4 years ago (2016-12-20 14:27:59 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/563f86cc38a6c97ce1116ffd4272b19cb8a06616
4 years ago (2016-12-20 14:33:01 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-20 14:34:27 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e536476bf377f0d41c7b4e1514e1ac9180e17ce3
Cr-Commit-Position: refs/heads/master@{#439796}

Powered by Google App Engine
This is Rietveld 408576698