cloud_print/virtual_driver/win/port_monitor/port_monitor.cc - Issue 2590433003: Re-enable building both 32 and 64 bit version of the GCP port monitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

Issue 2590433003: Re-enable building both 32 and 64 bit version of the GCP port monitor. (Closed)

Patch Set: Fix some issues with 32/64 bit installation. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

diff --git a/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc b/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

index 8748bb627cf85e912193d1e17bb0a85cef25340b..4c25e35aafa4e158b1acb21696cff39c23d3f8c6 100644

--- a/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

+++ b/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

@@ -629,7 +629,7 @@ DWORD WINAPI Monitor2XcvDataPort(HANDLE xcv_handle,

// dynamic creation of ports.

if (lstrcmp(L"MonitorUI", data_name) == 0) {

DWORD dll_path_len = 0;

- base::FilePath dll_path(L"gcp_portmon.dll");

+ base::FilePath dll_path(cloud_print::GetPortMonitorDllName());

dll_path_len = static_cast<DWORD>(dll_path.value().length());

if (output_data_bytes_needed != NULL) {

*output_data_bytes_needed = dll_path_len;