Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2590393002: Revert of Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, arv+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, eric.carlson_apple.com, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gogerald+paymentswatch_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, qsr+mojo_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, Srirama, timvolodine, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (patchset #9 id:160001 of https://codereview.chromium.org/2571903003/ ) Reason for revert: Possibly caused flakiness of WebUIMojoTest.EndToEndPing https://bugs.chromium.org/p/chromium/issues/detail?id=676071 Original issue's description: > Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". > > BUG=579646 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553 > Cr-Commit-Position: refs/heads/master@{#439615} TBR=rockot@chromium.org,eugenebut@chromium.org,jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579646 Committed: https://crrev.com/89bdaa17e67a2346f0c8c9ff04f54f35568f79e1 Cr-Commit-Position: refs/heads/master@{#439874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -143 lines) Patch
M chrome/browser/resources/bluetooth_internals/adapter_broker.js View 5 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/resources/bluetooth_internals/bluetooth_internals.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bluetooth_internals/interfaces.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/engagement/site_engagement.js View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/omnibox/omnibox.js View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/resources/plugins.js View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/resources/usb_internals/usb_internals.js View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/test/data/webui/bluetooth_internals_browsertest.js View 5 chunks +10 lines, -3 lines 0 comments Download
M chrome/test/data/webui/plugins_browsertest.js View 2 chunks +8 lines, -9 lines 0 comments Download
M content/test/data/web_ui_mojo.js View 1 chunk +6 lines, -5 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 6 chunks +20 lines, -9 lines 0 comments Download
M extensions/renderer/resources/mime_handler_private_custom_bindings.js View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/test/data/api_test_base_unittest.js View 1 chunk +3 lines, -3 lines 0 comments Download
M headless/lib/embedder_mojo_browsertest.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M headless/test/data/page_one.html View 1 chunk +9 lines, -3 lines 0 comments Download
M headless/test/data/page_two.html View 1 chunk +9 lines, -3 lines 0 comments Download
M ios/web/test/data/mojo_test.js View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js View 1 chunk +10 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js View 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/nfc/resources/nfc-helpers.js View 5 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js View 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js View 8 chunks +22 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js View 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js View 2 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
yzshen1
Created Revert of Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".
4 years ago (2016-12-20 20:17:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590393002/1
4 years ago (2016-12-20 20:17:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 20:19:10 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-20 20:21:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89bdaa17e67a2346f0c8c9ff04f54f35568f79e1
Cr-Commit-Position: refs/heads/master@{#439874}

Powered by Google App Engine
This is Rietveld 408576698