Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2418)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/omnibox/omnibox.js

Issue 2590393002: Revert of Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/engagement/site_engagement.js ('k') | chrome/browser/resources/plugins.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/omnibox/omnibox.js
diff --git a/chrome/browser/resources/omnibox/omnibox.js b/chrome/browser/resources/omnibox/omnibox.js
index 2570deb46d9d758f4244614d8b4da7fe751ee3bf..11c4a9939d948dcfa02e842863197c216b318f50 100644
--- a/chrome/browser/resources/omnibox/omnibox.js
+++ b/chrome/browser/resources/omnibox/omnibox.js
@@ -416,15 +416,18 @@
function initializeProxies() {
return importModules([
'mojo/public/js/bindings',
+ 'mojo/public/js/connection',
'chrome/browser/ui/webui/omnibox/omnibox.mojom',
'content/public/renderer/frame_interfaces',
]).then(function(modules) {
var bindings = modules[0];
- var mojom = modules[1];
- var frameInterfaces = modules[2];
-
- browserProxy = new mojom.OmniboxPageHandlerPtr(
- frameInterfaces.getInterface(mojom.OmniboxPageHandler.name));
+ var connection = modules[1];
+ var mojom = modules[2];
+ var frameInterfaces = modules[3];
+
+ browserProxy = connection.bindHandleToProxy(
+ frameInterfaces.getInterface(mojom.OmniboxPageHandler.name),
+ mojom.OmniboxPageHandler);
/** @constructor */
var OmniboxPageImpl = function() {
« no previous file with comments | « chrome/browser/resources/engagement/site_engagement.js ('k') | chrome/browser/resources/plugins.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698