Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2590313002: Added Blame.AddReagions(iterable) method (Closed)

Created:
4 years ago by wrengr
Modified:
4 years ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : inlining some single-use variables #

Total comments: 2

Patch Set 3 : changing Blame.AddRegions to use list.extend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -47 lines) Patch
M appengine/findit/crash/test/changelist_classifier_test.py View 1 chunk +3 lines, -4 lines 0 comments Download
M appengine/findit/crash/test/suspect_test.py View 1 chunk +7 lines, -10 lines 0 comments Download
M appengine/findit/libs/gitiles/blame.py View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M appengine/findit/libs/gitiles/test/blame_test.py View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py View 1 2 chunks +8 lines, -11 lines 0 comments Download
M appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py View 1 1 chunk +3 lines, -5 lines 0 comments Download
M appengine/findit/waterfall/test/build_failure_analysis_test.py View 1 chunk +16 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
wrengr
PTAL
4 years ago (2016-12-20 18:02:42 UTC) #3
stgao
lgtm with nits. https://codereview.chromium.org/2590313002/diff/20001/appengine/findit/libs/gitiles/blame.py File appengine/findit/libs/gitiles/blame.py (right): https://codereview.chromium.org/2590313002/diff/20001/appengine/findit/libs/gitiles/blame.py#newcode50 appengine/findit/libs/gitiles/blame.py:50: self.AddRegion(region) self.extend(list)?
4 years ago (2016-12-20 18:33:11 UTC) #4
Sharu Jiang
lgtm
4 years ago (2016-12-20 18:50:18 UTC) #5
wrengr
https://codereview.chromium.org/2590313002/diff/20001/appengine/findit/libs/gitiles/blame.py File appengine/findit/libs/gitiles/blame.py (right): https://codereview.chromium.org/2590313002/diff/20001/appengine/findit/libs/gitiles/blame.py#newcode50 appengine/findit/libs/gitiles/blame.py:50: self.AddRegion(region) On 2016/12/20 18:33:11, stgao (slow on Monday) wrote: ...
4 years ago (2016-12-20 19:56:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590313002/40001
4 years ago (2016-12-20 19:57:08 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 20:06:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/00ccad6ac3e1f3ab5e4a17625dddd...

Powered by Google App Engine
This is Rietveld 408576698