appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py - Issue 2590313002: Added Blame.AddReagions(iterable) method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

Issue 2590313002: Added Blame.AddReagions(iterable) method (Closed)

Patch Set: changing Blame.AddRegions to use list.extend Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py ('k') | appengine/findit/waterfall/test/build_failure_analysis_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

diff --git a/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py b/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

index e1a9bac290d16a074c2db77040b7e0cac61209bc..47ad698bd7d60ee358a77b79e8c64e45b5cfaad1 100644

--- a/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

+++ b/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

@@ -197,12 +197,10 @@ class LocalGitRepositoryTest(testing.AppengineTestCase):

"""

)

self.mock(script_util, 'GetCommandOutput', lambda *_: output)

- expected_regions = [blame.Region(18, 3, 'revision_hash', 'test@google.com',

- 'test@google.com',

- datetime(2013, 03, 11, 17, 13, 36))]

expected_blame = blame.Blame('src/core/SkFont.h', 'rev')

- for expected_region in expected_regions:

- expected_blame.AddRegion(expected_region)

+ expected_blame.AddRegions([

+ blame.Region(18, 3, 'revision_hash', 'test@google.com', 'test@google.com',

+ datetime(2013, 03, 11, 17, 13, 36))])

blame_result = self.local_repo.GetBlame('src/core/SkFont.h', 'rev')

self.assertTrue(blame_result.revision, expected_blame.revision)