Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2590283002: [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| (Closed)

Created:
4 years ago by chongz
Modified:
4 years ago
Reviewers:
tkent, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| |inputType()| was added before but never used, please see bug for more info. This CL doesn't have any behavior change. BUG=675979 Committed: https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f Cr-Commit-Position: refs/heads/master@{#440193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.h View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
chongz
xiaochengh@ This is the |UndoStep| CL isolated from the 'beforeinput' one, PTAL, thanks!
4 years ago (2016-12-20 23:21:07 UTC) #6
Xiaocheng
lgtm +tkent
4 years ago (2016-12-21 00:35:07 UTC) #8
tkent
lgtm
4 years ago (2016-12-21 01:07:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590283002/1
4 years ago (2016-12-21 18:17:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 20:05:16 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f Cr-Commit-Position: refs/heads/master@{#440193}
4 years ago (2016-12-21 20:09:10 UTC) #16
chongz
3 years, 11 months ago (2017-01-13 16:33:13 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2637443002/ by chongz@chromium.org.

The reason for reverting is: We want to revert all CLs and start over the
refactor process, see:
https://crbug.com/673789.

TBR=yosin@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698