Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

Issue 2590283002: [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
index 39ffedf1bb80c08f6a62ab4ebd3e10edd2c36d17..f6c2930ffa5ed34bbca22557c192a8fac3e8c561 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
@@ -48,13 +48,11 @@ class EditCommandComposition final : public UndoStep {
public:
static EditCommandComposition* create(Document*,
const VisibleSelection&,
- const VisibleSelection&,
- InputEvent::InputType);
+ const VisibleSelection&);
bool belongsTo(const LocalFrame&) const override;
void unapply(EditCommandSource) override;
void reapply(EditCommandSource) override;
- InputEvent::InputType inputType() const override;
void append(SimpleEditCommand*);
void append(EditCommandComposition*);
@@ -76,8 +74,7 @@ class EditCommandComposition final : public UndoStep {
private:
EditCommandComposition(Document*,
const VisibleSelection& startingSelection,
- const VisibleSelection& endingSelection,
- InputEvent::InputType);
+ const VisibleSelection& endingSelection);
// TODO(chongz): Implement "beforeinput" as described below:
// Fires "beforeinput" and will returns |false| to cancel unapply / reapply if
@@ -93,7 +90,6 @@ class EditCommandComposition final : public UndoStep {
HeapVector<Member<SimpleEditCommand>> m_commands;
Member<Element> m_startingRootEditableElement;
Member<Element> m_endingRootEditableElement;
- InputEvent::InputType m_inputType;
};
class CORE_EXPORT CompositeEditCommand : public EditCommand {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698