Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2590263002: Revert of Use classic GAE for coordinator default frontend. (Closed)

Created:
4 years ago by dnj
Modified:
4 years ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Revert of Use classic GAE for coordinator default frontend. (patchset #2 id:20001 of https://codereview.chromium.org/2591443002/ ) Reason for revert: This works! But doing this through socket API is measurably slower: Logs for 6MB responses: Classic: 12s, 12s MVM: 1.9s, 2, 2, 2.1s Original issue's description: > Use classic GAE for coordinator default frontend. > > Now that AppEngine sockets API is default-integrated into gRPC calls, we > no longer need to run on a Managed VM in order to perform HTTP2 > connections to BigTable. Since classic scales better (ATM), let's switch > to that. > > BUG=None > TEST=dev > R=vadimsh@chromium.org > > Review-Url: https://codereview.chromium.org/2591443002 > Committed: https://github.com/luci/luci-go/commit/bde0f949595b702559b9c96be85a0d405ffad1f2 TBR=vadimsh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2590263002 Committed: https://github.com/luci/luci-go/commit/31a0a28a8808261ee63d6c2d9fb22c726f70c6db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M logdog/appengine/cmd/coordinator/vmuser/doc.go View 1 chunk +4 lines, -3 lines 0 comments Download
M logdog/appengine/cmd/coordinator/vmuser/main.go View 4 chunks +4 lines, -2 lines 0 comments Download
M logdog/appengine/cmd/coordinator/vmuser/module.cfg View 1 chunk +8 lines, -0 lines 0 comments Download
M logdog/appengine/coordinator/service.go View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
Created Revert of Use classic GAE for coordinator default frontend.
4 years ago (2016-12-20 16:00:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590263002/1
4 years ago (2016-12-20 16:00:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/31a0a28a8808261ee63d6c2d9fb22c726f70c6db
4 years ago (2016-12-20 16:00:56 UTC) #6
Vadim Sh.
4 years ago (2016-12-20 20:40:43 UTC) #7
Message was sent while issue was closed.
On 2016/12/20 16:00:56, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://github.com/luci/luci-go/commit/31a0a28a8808261ee63d6c2d9fb22c726f70c6db

lgtm

:'(

Powered by Google App Engine
This is Rietveld 408576698