Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2591443002: Use classic GAE for coordinator default frontend. (Closed)

Created:
4 years ago by dnj
Modified:
4 years ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Use classic GAE for coordinator default frontend. Now that AppEngine sockets API is default-integrated into gRPC calls, we no longer need to run on a Managed VM in order to perform HTTP2 connections to BigTable. Since classic scales better (ATM), let's switch to that. BUG=None TEST=dev R=vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2591443002 Committed: https://github.com/luci/luci-go/commit/bde0f949595b702559b9c96be85a0d405ffad1f2

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M logdog/appengine/cmd/coordinator/vmuser/doc.go View 1 chunk +3 lines, -4 lines 0 comments Download
M logdog/appengine/cmd/coordinator/vmuser/main.go View 1 4 chunks +2 lines, -4 lines 0 comments Download
M logdog/appengine/cmd/coordinator/vmuser/module.cfg View 1 1 chunk +0 lines, -8 lines 0 comments Download
M logdog/appengine/coordinator/service.go View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dnj
PTAL! Now that I am aware of the socket API, the last reason to use ...
4 years ago (2016-12-19 16:14:53 UTC) #1
Vadim Sh.
lgtm I hope it works...
4 years ago (2016-12-19 20:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591443002/1
4 years ago (2016-12-20 02:46:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3332f17e07c4d210) ...
4 years ago (2016-12-20 02:48:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591443002/20001
4 years ago (2016-12-20 03:10:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-go/commit/bde0f949595b702559b9c96be85a0d405ffad1f2
4 years ago (2016-12-20 03:15:49 UTC) #12
dnj
4 years ago (2016-12-20 16:00:36 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2590263002/ by dnj@chromium.org.

The reason for reverting is: This works! But doing this through socket API is
measurably slower:

Logs for 6MB responses:
Classic: 12s, 12s

MVM: 1.9s, 2, 2, 2.1s.

Powered by Google App Engine
This is Rietveld 408576698