Issue 2590163005: [css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2590163005: [css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax (Closed)

Created:
4 years ago by cbiesinger

Modified:
4 years ago

Reviewers:
mstensho (USE GERRIT), eae

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax When stretching we used to pass the wrong available width to constrainLogicalWidthByMinMax, leading to an incorrect calculation of percentage max/min widths. BUG=675333 R=mstensho@opera.com,eae@chromium.org Review-Url: https://codereview.chromium.org/2585423002 Cr-Commit-Position: refs/heads/master@{#439772} (cherry picked from commit 1691bb109535d456e52402b7fd2a82f02c1ba853) Committed: https://chromium.googlesource.com/chromium/src/+/40a286ebdbf149c1f7f8cb92fdb91ab46d1a0ace

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -2 lines)			Patch
	A	third_party/WebKit/LayoutTests/css3/flexbox/percentage-max-width-cross-axis.html	View		1 chunk	+22 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

cbiesinger

4 years ago (2016-12-21 13:39:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
40a286ebdbf149c1f7f8cb92fdb91ab46d1a0ace.