Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2585423002: [css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax (Closed)

Created:
4 years ago by cbiesinger
Modified:
4 years ago
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax When stretching we used to pass the wrong available width to constrainLogicalWidthByMinMax, leading to an incorrect calculation of percentage max/min widths. BUG=675333 R=mstensho@opera.com,eae@chromium.org Committed: https://crrev.com/1691bb109535d456e52402b7fd2a82f02c1ba853 Cr-Commit-Position: refs/heads/master@{#439772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/percentage-max-width-cross-axis.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
cbiesinger
4 years ago (2016-12-19 23:27:15 UTC) #1
mstensho (USE GERRIT)
lgtm
4 years ago (2016-12-20 09:22:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585423002/1
4 years ago (2016-12-20 12:11:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 12:21:36 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 12:23:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1691bb109535d456e52402b7fd2a82f02c1ba853
Cr-Commit-Position: refs/heads/master@{#439772}

Powered by Google App Engine
This is Rietveld 408576698