third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp - Issue 2590163005: [css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2590163005: [css-flexbox] Pass correct available width to constrainLogicalWidthByMinMax (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

index f0845d6f7ea2938fdebd7038423200fff6ca44cb..66d331d0c5f2dd84e95a27459e53f0ada64f348c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

@@ -2130,8 +2130,8 @@ void LayoutFlexibleBox::applyStretchAlignmentToChild(

LayoutUnit childWidth =

(lineCrossAxisExtent - crossAxisMarginExtentForChild(child))

.clampNegativeToZero();

- childWidth =

- child.constrainLogicalWidthByMinMax(childWidth, childWidth, this);

+ childWidth = child.constrainLogicalWidthByMinMax(

+ childWidth, crossAxisContentExtent(), this);

if (childWidth != child.logicalWidth()) {

child.setOverrideLogicalContentWidth(

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/flexbox/percentage-max-width-cross-axis.html ('k') | no next file » | no next file with comments »