|
|
Created:
4 years ago by Evan Stade Modified:
4 years ago Reviewers:
Peter Kasting CC:
chromium-reviews, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't request focus on press for buttons in profile menu.
This prevents showing a dotted outline around a user row
(in addition to the grey bg hover effect) when you click and hold.
The only reason these were all explicitly set to request focus on
press is because the default value for that bit was flipped back in
May and most existing buttons were mechanically updated to stick with
the old default.
The focus effect should probably also be updated to something more MD-
looking for when you do tab to a row, but that's left as an exercise for
the future.
BUG=none
Committed: https://crrev.com/7a5951c0df12e6b7d58d09ba3206a112c8293662
Cr-Commit-Position: refs/heads/master@{#439861}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== Don't request focus on press for buttons in profile menu. This prevents, for example, showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none ========== to ========== Don't request focus on press for buttons in profile menu. This prevents, for example, showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none ==========
estade@chromium.org changed reviewers: + pkasting@chromium.org
Description was changed from ========== Don't request focus on press for buttons in profile menu. This prevents, for example, showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none ========== to ========== Don't request focus on press for buttons in profile menu. This prevents showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none ==========
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1482256407201920, "parent_rev": "607b25ce6bf7f8008b925e280c487362981f18df", "commit_rev": "13e29380c873185b569151d76e45f5d97128e3d5"}
Message was sent while issue was closed.
Description was changed from ========== Don't request focus on press for buttons in profile menu. This prevents showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none ========== to ========== Don't request focus on press for buttons in profile menu. This prevents showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none Review-Url: https://codereview.chromium.org/2589863002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't request focus on press for buttons in profile menu. This prevents showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none Review-Url: https://codereview.chromium.org/2589863002 ========== to ========== Don't request focus on press for buttons in profile menu. This prevents showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none Committed: https://crrev.com/7a5951c0df12e6b7d58d09ba3206a112c8293662 Cr-Commit-Position: refs/heads/master@{#439861} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7a5951c0df12e6b7d58d09ba3206a112c8293662 Cr-Commit-Position: refs/heads/master@{#439861} |