Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2589863002: Don't request focus on press for buttons in profile menu. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't request focus on press for buttons in profile menu. This prevents showing a dotted outline around a user row (in addition to the grey bg hover effect) when you click and hold. The only reason these were all explicitly set to request focus on press is because the default value for that bit was flipped back in May and most existing buttons were mechanically updated to stick with the old default. The focus effect should probably also be updated to something more MD- looking for when you do tab to a row, but that's left as an exercise for the future. BUG=none Committed: https://crrev.com/7a5951c0df12e6b7d58d09ba3206a112c8293662 Cr-Commit-Position: refs/heads/master@{#439861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Evan Stade
4 years ago (2016-12-19 16:04:21 UTC) #6
Peter Kasting
LGTM
4 years ago (2016-12-20 02:52:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589863002/1
4 years ago (2016-12-20 17:53:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 19:07:38 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-20 19:11:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a5951c0df12e6b7d58d09ba3206a112c8293662
Cr-Commit-Position: refs/heads/master@{#439861}

Powered by Google App Engine
This is Rietveld 408576698