Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2868)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 2589863002: Don't request focus on press for buttons in profile menu. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index f2a8cfdbc1fe475bdac149e13d18842ad727a703..d45dbb6c7712fefd4e2439c367d0a29299d2747d 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -177,7 +177,6 @@ views::ImageButton* CreateBackButton(views::ButtonListener* listener) {
back_button->SetImage(views::ImageButton::STATE_DISABLED,
rb->GetImageSkiaNamed(IDR_BACK_D));
back_button->SetFocusForPlatform();
- back_button->set_request_focus_on_press(true);
return back_button;
}
@@ -197,7 +196,6 @@ class BackgroundColorHoverButton : public views::LabelButton {
: views::kButtonHEdgeMarginNew;
SetBorder(views::CreateEmptyBorder(0, button_margin, 0, button_margin));
SetFocusForPlatform();
- set_request_focus_on_press(true);
if (switches::IsMaterialDesignUserMenu()) {
label()->SetHandlesTooltips(false);
@@ -1623,7 +1621,6 @@ views::View* ProfileChooserView::CreateCurrentProfileView(
gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,
gfx::kChromeIconGrey));
auth_error_email_button_->SetFocusForPlatform();
- auth_error_email_button_->set_request_focus_on_press(true);
gfx::Insets insets =
views::LabelButtonAssetBorder::GetDefaultInsetsForStyle(
views::Button::STYLE_TEXTBUTTON);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698