Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2589683003: [foozzie] Add sources metadata to failure output. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
tandrii(chromium)
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Add sources metadata to failure output. BUG=chromium:673246 NOTRY=true Review-Url: https://codereview.chromium.org/2589683003 Cr-Commit-Position: refs/heads/master@{#41844} Committed: https://chromium.googlesource.com/v8/v8/+/5173b0fb784e36befa874551644404b81f84f8c4

Patch Set 1 #

Patch Set 2 : files #

Patch Set 3 : Rebase #

Patch Set 4 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M tools/foozzie/testdata/failure_output.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A tools/foozzie/testdata/meta-test1.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
A tools/foozzie/testdata/resources-test1.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/foozzie/v8_foozzie.py View 4 chunks +22 lines, -1 line 0 comments Download
M tools/presubmit.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
Michael Achenbach
PTAL
4 years ago (2016-12-19 11:44:55 UTC) #2
tandrii(chromium)
lgtm
4 years ago (2016-12-19 13:19:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589683003/40001
4 years ago (2016-12-20 09:57:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31039)
4 years ago (2016-12-20 09:59:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589683003/60001
4 years ago (2016-12-20 10:07:48 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 10:09:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/5173b0fb784e36befa874551644404b81f8...

Powered by Google App Engine
This is Rietveld 408576698