[foozzie] Add some system tests.

[foozzie] Add some system tests.

BUG=chromium:673246
NOTRY=true

Review-Url: https://codereview.chromium.org/2585193003
Cr-Commit-Position: refs/heads/master@{#41836}
Committed: https://chromium.googlesource.com/v8/v8/+/7e8bd39a4993590eee5fdfe5936b22a2cc2621db

[Michael Achenbach, 2016-12-19 11:05:00]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2016-12-19 11:05:01]

PTAL

[tandrii(chromium), 2016-12-19 13:25:34]

LGTM % assertRaises

https://codereview.chromium.org/2585193003/diff/20001/tools/foozzie/v8_foozzi...
File tools/foozzie/v8_foozzie_test.py (right):

https://codereview.chromium.org/2585193003/diff/20001/tools/foozzie/v8_foozzi...
tools/foozzie/v8_foozzie_test.py:109: assert False
assertionError is also Exception, so better:

with self.assertRaises(subprocess.CalledProcessError) as ctx:
  run(...)
e = ctx.exception
self.assertEquals(v8_foozzie.RETURN_FAIL, e.returncode)

[Michael Achenbach, 2016-12-20 09:22:30]

https://codereview.chromium.org/2585193003/diff/20001/tools/foozzie/v8_foozzi...
File tools/foozzie/v8_foozzie_test.py (right):

https://codereview.chromium.org/2585193003/diff/20001/tools/foozzie/v8_foozzi...
tools/foozzie/v8_foozzie_test.py:109: assert False
On 2016/12/19 13:25:34, tandrii(chromium) wrote:
> assertionError is also Exception, so better:
> 
> with self.assertRaises(subprocess.CalledProcessError) as ctx:
>   run(...)
> e = ctx.exception
> self.assertEquals(v8_foozzie.RETURN_FAIL, e.returncode)

Done.

[Michael Achenbach, 2016-12-20 09:22:42]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-12-20 09:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2585193003/#ps40001
(title: "Review")

[commit-bot: I haz the power, 2016-12-20 09:22:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 09:33:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482225762531550,
"parent_rev": "f6d8ec4fca8952b4c14e91d7f5018a1f2fcfa64f", "commit_rev":
"7e8bd39a4993590eee5fdfe5936b22a2cc2621db"}

[commit-bot: I haz the power, 2016-12-20 09:33:59]

Description was changed from

==========
[foozzie] Add some system tests.

BUG=chromium:673246
NOTRY=true
==========

to

==========
[foozzie] Add some system tests.

BUG=chromium:673246
NOTRY=true

Review-Url: https://codereview.chromium.org/2585193003
Cr-Commit-Position: refs/heads/master@{#41836}
Committed:
https://chromium.googlesource.com/v8/v8/+/7e8bd39a4993590eee5fdfe5936b22a2cc2...
==========

[commit-bot: I haz the power, 2016-12-20 09:34:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/7e8bd39a4993590eee5fdfe5936b22a2cc2...