Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2589663003: mojo:: Rename mojo::GetProxy() to mojo::MakeRequest() (Closed)

Created:
4 years ago by blundell
Modified:
4 years ago
CC:
chromium-reviews, sadrul, abhishekbh_chromium.org, blink-reviews-platform-graphics_chromium.org, nasko+codewatch_chromium.org, kmarshall+watch-blimp_chromium.org, alokp+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, krit, toyoshim+midi_chromium.org, bgoldman+watch-blimp_chromium.org, sebsg+autofillwatch_chromium.org, gcasto+watch-blimp_chromium.org, nona+watch_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, kalyank, ajuma+watch_chromium.org, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, dshwang, Randy Smith (Not in Mondays), loading-reviews_chromium.org, mlamouri+watch-sensors_chromium.org, jochen+watch_chromium.org, rjkroege, mlamouri+watch-test-runner_chromium.org, tfarina, avayvod+watch_chromium.org, perumaal+watch-blimp_chromium.org, f(malita), riju_, estade+watch_chromium.org, isheriff+watch_chromium.org, mmenke, dominickn+watch_chromium.org, viettrungluu+watch_chromium.org, scheib+watch_chromium.org, lhchavez+watch_chromium.org, agrieve+watch_chromium.org, kinuko+watch, rwlbuis, drott+blinkwatch_chromium.org, mvanouwerkerk+watch_chromium.org, iclelland+watch_chromium.org, chasej+watch_chromium.org, marcinjb+watch-blimp_chromium.org, Rik, lethalantidote+watch-blimp_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nhiroki, feature-vr-reviews_chromium.org, timvolodine, asvitkine+watch_chromium.org, shimazu+serviceworker_chromium.org, sriramsr+watch-blimp_chromium.org, rouslan+payments_chromium.org, serviceworker-reviews, sebsg+paymentswatch_chromium.org, horo+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, blink-reviews, browser-components-watch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, awdf+watch_chromium.org, yhirano+watch_chromium.org, chromoting-reviews_chromium.org, Justin Novosad, abarth-chromium, darin-cc_chromium.org, jkarlin+watch_chromium.org, xjz+watch_chromium.org, blink-worker-reviews_chromium.org, elijahtaylor+arcwatch_chromium.org, imcheng+watch_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, sof, jbroman, piman+watch_chromium.org, Kevin Cernekee, khushalsagar+watch-blimp_chromium.org, tyoshino+watch_chromium.org, anandc+watch-blimp_chromium.org, shalamov, mlamouri+watch-blink_chromium.org, shuchen+watch_chromium.org, gogerald+paymentswatch_chromium.org, Aaron Boodman, cmumford, ortuno+watch_chromium.org, Stephen Chennney, James Su, kinuko+fileapi, erickung+watch_chromium.org, qsr+mojo_chromium.org, tzik, posciak+watch_chromium.org, eae+blinkwatch, apacible+watch_chromium.org, darin (slow to review), cbentzel+watch_chromium.org, pdr+graphicswatchlist_chromium.org, maniscalco+watch-blimp_chromium.org, jbauman+watch_chromium.org, blink-reviews-dom_chromium.org, wanming.lin, pkotwicz+watch_chromium.org, Sameer Nanda, vabr+watchlistpasswordmanager_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, zpeng+watch_chromium.org, michaeln, media-router+watch_chromium.org, mathp+autofillwatch_chromium.org, steimel+watch-blimp_chromium.org, jdonnelly+autofillwatch_chromium.org, kinuko+serviceworker, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo:: Rename mojo::GetProxy() to mojo::MakeRequest() In https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM, we decided that mojo::MakeRequest was a more suitable name for this helper function than mojo::GetProxy. This CL was created by running mass search-and-replace (suitably guarded to avoid changing unrelated GetProxy() functions), followed by "git cl format". CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=darin Committed: https://crrev.com/e0a9f158f10a9f5ee5d21d571518ff46929af89f Cr-Commit-Position: refs/heads/master@{#439767}

Patch Set 1 #

Patch Set 2 : Catch a couple strays #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -537 lines) Patch
M ash/mus/window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/mojo/font_fetcher_mojo_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/cast_remoting_connector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/cast_remoting_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_resource_usage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/providers/child_process_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ime_driver/ime_driver_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webshare/share_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_arc_video_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/crash_collector/arc_crash_collector_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/metrics/arc_metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 21 chunks +21 lines, -21 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 1 11 chunks +12 lines, -12 lines 0 comments Download
M components/leveldb/remote_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/child_call_stack_profile_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/test_runner/app_banner_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/translate/content/renderer/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java_interfaces_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/downloaded_temp_file_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/media/media_interface_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/websockets/websocket_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/associated_interface_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/service_manager/child_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/utility_process_mojo_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/associated_interface_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/bluetooth/web_bluetooth_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/device_sensors/device_sensor_event_pump.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_storage/local_storage_cached_area.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/gamepad_shared_memory_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_devices_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_permission_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_device_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/adapter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/adapter_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/sensor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/power_monitor/power_monitor_message_broadcaster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/power_monitor/public/cpp/power_monitor_broadcast_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_service_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/vr/vr_device_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/vr_display_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/vr_display_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/vr_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mojo/keep_alive_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/webtest/webtest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/clients/mojo_audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_cdm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_renderer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_service_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/strong_binding_set_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M media/remoting/fake_remoting_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/remoting/remote_demuxer_stream_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/remoting/remoting_cdm_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/remoting/remoting_source_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/common_custom_types_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M mojo/edk/js/tests/js_to_cpp_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/binding_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 11 chunks +18 lines, -18 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/binding_callback_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/binding_set_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/tests/binding_unittest.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/data_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/equals_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 20 chunks +26 lines, -25 lines 0 comments Download
M mojo/public/cpp/bindings/tests/pickle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/report_bad_message_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_traits_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/thread_safe_interface_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mojo_host_resolver_impl_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/proxy/in_process_mojo_proxy_resolver_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_factory_mojo.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_factory_mojo_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/catalog/catalog.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/navigation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/public/cpp/view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/preferences/public/cpp/tests/pref_observer_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/README.md View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/connect_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/cpp/lib/connector_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/lib/interface_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/service_manager/service_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/service_manager/standalone/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/lifecycle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/service_manager/service_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/tracing/public/cpp/provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ime/ime_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ime/test_ime_driver/test_ime_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/window_compositor_frame_sink.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M services/ui/public/cpp/window_tree_host_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/gpu_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_manager_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_tree_binding.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/test/fake_device_descriptor_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M services/video_capture/test/fake_device_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/test/fake_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/video_capture/test/mock_device_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/video_capture/test/service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/test/service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/budget/BudgetService.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationManager.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mojo/CommonCustomTypesStructTraitsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mojo/KURLSecurityOriginTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/input_method_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_compositor_frame_sink.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/input_method_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/mojo/url_gurl_struct_traits_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (21 generated)
blundell
Hey John, You're the lucky one as I know that you're in the office ;). ...
4 years ago (2016-12-19 16:53:10 UTC) #11
jam
On 2016/12/19 16:53:10, blundell wrote: > Hey John, > > You're the lucky one as ...
4 years ago (2016-12-19 18:25:32 UTC) #14
jam
On 2016/12/19 16:53:10, blundell wrote: > Hey John, > > You're the lucky one as ...
4 years ago (2016-12-19 18:25:33 UTC) #15
yzshen1
On 2016/12/19 18:25:33, jam wrote: > On 2016/12/19 16:53:10, blundell wrote: > > Hey John, ...
4 years ago (2016-12-19 19:26:39 UTC) #16
haraken
WebKit LGTM
4 years ago (2016-12-20 00:11:23 UTC) #17
blundell
TBR=darin for all of the callsites of mojo::GetProxy().
4 years ago (2016-12-20 07:11:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589663003/20001
4 years ago (2016-12-20 07:12:21 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/329647)
4 years ago (2016-12-20 07:21:47 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589663003/40001
4 years ago (2016-12-20 09:11:04 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 11:24:06 UTC) #30
commit-bot: I haz the power
4 years ago (2016-12-20 11:26:18 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0a9f158f10a9f5ee5d21d571518ff46929af89f
Cr-Commit-Position: refs/heads/master@{#439767}

Powered by Google App Engine
This is Rietveld 408576698