Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2589633003: Remove a comment on LocalFrame::setDOMWindow (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a comment on LocalFrame::setDOMWindow The comment is too out-dated and I don't understand. It would be better to remove the comment. BUG= Committed: https://crrev.com/a5a1ba20c83944bc14cf01573392905945f8038c Cr-Commit-Position: refs/heads/master@{#439441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
4 years ago (2016-12-19 05:18:41 UTC) #2
sof
lgtm That comment has always been a bit out of place, but put there to ...
4 years ago (2016-12-19 08:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589633003/1
4 years ago (2016-12-19 08:03:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 09:25:06 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 09:28:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5a1ba20c83944bc14cf01573392905945f8038c
Cr-Commit-Position: refs/heads/master@{#439441}

Powered by Google App Engine
This is Rietveld 408576698