Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2589633003: Remove a comment on LocalFrame::setDOMWindow (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 3d7b6aea9d31d280911a5bb409e2fa776562fd5b..a689013eb1b512f0f5a3b67a027a5bd489add3ae 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -506,21 +506,6 @@ LocalDOMWindow* LocalFrame::domWindow() const {
}
void LocalFrame::setDOMWindow(LocalDOMWindow* domWindow) {
- // TODO(haraken): Update this comment.
- // Oilpan: setDOMWindow() cannot be used when finalizing. Which
- // is acceptable as its actions are either not needed or handled
- // by other means --
- //
- // - LocalFrameLifecycleObserver::willDetachFrameHost() will have
- // signalled the Inspector frameWindowDiscarded() notifications.
- // We assume that all LocalFrames are detached, where that notification
- // will have been done.
- //
- // - Calling LocalDOMWindow::reset() is not needed (called from
- // Frame::setDOMWindow().) The Member references it clears will now
- // die with the window. And the registered DOMWindowProperty instances that
- // don't, only keep a weak reference to this frame, so there's no need to
- // be explicitly notified that this frame is going away.
if (domWindow)
script().clearWindowProxy();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698