Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2589493003: Specify TaskType of posted Task explicitly in popup UIs (8) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, Peter Beverloo, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in popup UIs This CL assigns TaskType::UserInteraction to the popup menu event and notification event. For Notification API event, the spec doesn't specify the task source explicitly. TaskType::UserInteraction should be the best fit here. https://notifications.spec.whatwg.org/ For popup menus, the event has non-web event source. TaskType::UserInteraction is the best fit here too. BUG=624696 Committed: https://crrev.com/10f963b41ab8dcea765528f187bde5c252e960ad Cr-Commit-Position: refs/heads/master@{#439389}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
tzik
PTAL
4 years ago (2016-12-18 14:41:51 UTC) #6
haraken
LGTM
4 years ago (2016-12-18 14:56:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589493003/20001
4 years ago (2016-12-18 23:28:30 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 00:51:35 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-19 00:53:42 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10f963b41ab8dcea765528f187bde5c252e960ad
Cr-Commit-Position: refs/heads/master@{#439389}

Powered by Google App Engine
This is Rietveld 408576698